Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map support for c# #433

Closed
anandolee opened this issue May 28, 2015 · 4 comments
Closed

map support for c# #433

anandolee opened this issue May 28, 2015 · 4 comments
Labels
c#
Milestone
C# proto3 support

Comments

@anandolee
Copy link
Contributor

I am going to add map support for c#.

Should implement a dictionary which has a "bool readOnly" like what PopsicleList.cs does. MakeReadOnly() will be called when build. Copy(or Merge) will be called before modify.

@jskeet
For Reflection API, c++ and java use different data representations and convert data between the two depending on which API is called. Do you think we should follow this?
@anandolee anandolee added the c# label May 28, 2015
@jskeet
Copy link
Contributor

jskeet commented May 28, 2015

I would prefer to just have a single version of the data structure, to me - as a user of the Java API it's never been entirely clear why there are two versions.

However, as I'm looking at an entirely-mutable version now, you may want to hold off on map support until we can decide one way or another on that. I guess it depends on how much of the work you think will be portable to the mutable version - all the serialization code will be portable, but I assume that's reasonably simple anyway.

@anandolee
Copy link
Contributor Author

We need to decide the mutable version. However protobuf team want the proto3 support for csharp ASAP. How long do you think we could make the decision for mutable Version?
Can you draft a plan for the mutable version?

@jskeet
Copy link
Contributor

jskeet commented May 30, 2015

Well I'm working on the mutable version as fast as I can bearing in mind that I'm on holiday :) I expect to be able to get a draft of the runtime working within the week, but I don't know how long the generator changes will take.

I think it will definitely be simpler to work with for those who haven't used the builder pattern before - at the cost of the benefits of immutability, of course. The current plan is to have just a mutable version of each message, but we could potentially add a "BuildImmutableClone" method later on.

@jtattermusch jtattermusch added this to the C# proto3 support milestone Jun 19, 2015
@jtattermusch
Copy link
Contributor

Implemented by #543 (and some minor changes afterwards)

adellahlou pushed a commit to adellahlou/protobuf that referenced this issue Apr 20, 2023
@dcodeIO
CLI: Added an experimental --sparse option to limit pbjs output to ac…
2ddb76b 
…tually referenced types within main files; Other: Added a few more common google types from google/api, see protocolbuffers#433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c#
Projects
None yet
Milestone
C# proto3 support
Development

No branches or pull requests
3 participants
@jskeet @jtattermusch @anandolee