Ruby C extension speedup: don't re-intern constant string needlessly. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,11 @@ | |||
| // ----------------------------------------------------------------------------- | |||
|
|
|||
| const char* kDescriptorInstanceVar = "descriptor"; | |||
| ID descriptor_instancevar_interned; | |||
There was a problem hiding this comment.
Since this is used in many files, seems to make sense to have it in the main file? Then you could just initialize it directly without needing a separate function.
Also fixed lines with > 80 char length.
|
Thanks! PTAL. |
|
LGTM |
haberman
added a commit
that referenced
this pull request
May 19, 2015
Ruby C extension speedup: don't re-intern constant string needlessly.
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Updated Bazel fuzzing to use the newest fuzz rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the C extension interned the string "descriptor" (to obtain a Ruby
IDvalue, which is an integer representation of an interned string) every time it needed to look up a descriptor object given a message class. This caused the interned-string table lookup, which uses a hashtable, to become a performance hotspot. Since the string is a constant, it makes much more sense to intern it once at initialization then use that value.Also fixed lines with > 80 char length.