Solves AOT compilation issue for Unity - iOS #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| internal class ExtensionIntPairEqualityComparer : IEqualityComparer<ExtensionIntPair> | ||
| { | ||
| public bool Equals (ExtensionIntPair x, ExtensionIntPair y) |
There was a problem hiding this comment.
code style: please remove the extra space between "Equals" and "(". Also below
…ExtensionRegistryLite.cs to prevent AOT compilation issue with unity in iOS
|
@jtattermusch I made the changes you requested, please let me know if you need me to make any more changes |
|
Hi, yes, I saw, thanks. There's nothing else I need from you, it's just I am fully focused on gRPC alpha release for the past few days, sorry for the delay. @jskeet feel free to to review and merge this if it looks good. |
|
LGTM. |
jtattermusch
added a commit
that referenced
this pull request
May 21, 2015
Solves AOT compilation issue for Unity - iOS
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
Properly unmarshal JSON "null" field value to nil for all WKTs except for Value type. This is consistent with regular message field types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using protobuf c# in unity for building iOS there is an issue with AOT compilation
---> System.TypeInitializationException: An exception was thrown by the type initializer for System.Collections.Generic.EqualityComparer1 ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ExecutionEngineException: Attempting to JIT compile method 'System.Collections.Generic.GenericEqualityComparer1:.ctor ()' while running with --aot-only.
The solution is to provide a concrete implementation of IEqualityComparer to avoid AOT compilation.
More references for this issue:
http://stackoverflow.com/questions/24368929/exception-attempting-to-jit-compile-method-while-running-with-aot-only-with
https://code.google.com/p/protobuf-csharp-port/issues/detail?id=98