Generate *all* protos in the script, applying fixups. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still have some protos which aren't generated how we want them to be: - Until we have an option to specify the "umbrella" class, DescriptorProtoFile will be broken. (The change of name here affects the reflection descriptor, which accounts for most of the change. That's easier than trying to work out exactly which occurrences of Descriptor need changing though.) - That change affects UnittestCustomOptions - Issue protocolbuffers#307 breaks Unittest.cs After this commit, we don't have the record of the fixups in the files themselves any more, but one centralized record in the shell script.
| @@ -26,7 +26,12 @@ if [ -z "$PROTOC" ]; then | |||
| fi | |||
|
|
|||
| # Descriptor proto | |||
| #TODO(jtattermusch): generate descriptor.proto | |||
| # Temporary manual fixup... | |||
There was a problem hiding this comment.
I'd say putting a comment that describes exacly what this temporary fixup is doing would be useful (basically just pasting the text from PR description here).
|
Besides the comment, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have some protos which aren't generated how we want them to be:
will be broken. (The change of name here affects the reflection descriptor,
which accounts for most of the change. That's easier than trying to work out
exactly which occurrences of Descriptor need changing though.)
After this commit, we don't have the record of the fixups in the files themselves
any more, but one centralized record in the shell script.
The big changes in csharp/src/ProtocolBuffersLite.Test/TestProtos/Unittest.cs is due to reformatting - it's not clear to me why this is different from the rest...