Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto generation for C# under Windows #375

Closed
jskeet opened this issue May 13, 2015 · 4 comments
Closed

Add proto generation for C# under Windows #375

jskeet opened this issue May 13, 2015 · 4 comments
Assignees
Labels

Comments

@jskeet
Copy link
Contributor

jskeet commented May 13, 2015

Pull request #373 added shell scripts to generate proto files under Unix; we should have the same ability for Windows when protoc.exe has already been built. Ideally this would be an msbuild target, but it could also be a batch script for the moment.

@jskeet jskeet added the c# label May 13, 2015
@jskeet jskeet self-assigned this May 13, 2015
@jtattermusch
Copy link
Contributor

I am almost leaning towards not creating a batch script for windows, so that we have a just a single file for regenerating proto and thus maintain its single source of truth status. Keeping two scripts that do the same thing in sync seem like a pain.
As you said, it would be good if we could come up with a nice portable way (perhaps msbuild/xbuild based) to regenerate the protos.

@jskeet
Copy link
Contributor Author

jskeet commented May 13, 2015

Well, without any way of regenerating the files on Windows, that basically makes it infeasible to develop the runtime in Windows - which would be pretty odd when that's the primary platform for most C# developers. An msbuild solution is definitely the ideal; will investigate it further. (We already have some code to do it, but it's out of date.)

@jskeet
Copy link
Contributor Author

jskeet commented May 14, 2015

I've started looking into msbuild, but it'll take quite a while to get my head round how to do it properly.
In the meantime, I've added a pull request to make generate_protos.sh find a suitable protoc file, probing vsprojects/Debug/protoc.exe, vsprojects/Release/protoc.exe, and src/protoc.

This should be a short term fix allowing development under Windows for anyone who has a Bash shell installed - which happens by default when you install msysgit...

@jskeet
Copy link
Contributor Author

jskeet commented Jan 28, 2016

Superceded by #1193.

@jskeet jskeet closed this as completed Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants