New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# generate_proto.sh and buildall.sh scripts #373
C# generate_proto.sh and buildall.sh scripts #373
Conversation
The regeneration would be due to the recent changes in protoc, yes - I hadn't regenerated since then. When this is committed, I'll regenerate using protoc.exe on Windows and my little batch file (uncommitted but similar) and compare the results for sanity. This change seems to have deleted some generated files though: From Lite:
... presumably these aren't used in the lite tests so are valid to remove.
It's not clear to me these three aren't needed - do we have test code that uses them, but is somehow not in the project file? Will look into that when I get some time. I still want to add support for doing all of this from msbuild/xbuild if possible, of course - and our "old" build scripts definitely have some of it in, but I'll need to investigate it carefully. I may well add a similar batch file (with an assumed location for protoc.exe - currently I've got it in my lib directory) for the moment, until I have time to look at this properly. Merging for the moment, but this PR has raised more things to do :) (I'll add issues to remind me to do them.) |
C# generate_proto.sh and buildall.sh scripts
I've just noticed this doesn't rebuild the AddressBook files. If we keep this shell script, we should fix that - but I'm still hoping to have an msbuild file... |
Oh yes, good catch, thanks.
|
-- some cleanup performed
-- buildall.sh script
-- generate_protos.sh script that regenerates proto files (as a result, it turned out lots of generated files are out of data, so I regenerated them when possible)
These files are handcrafted, so I left them as they are for now:
csharp/src/ProtocolBuffers.Test/TestProtos/Unittest.cs
csharp/src/ProtocolBuffers.Test/TestProtos/UnittestCustomOptions.cs
csharp/src/ProtocolBuffersLite.Test/TestProtos/Unittest.cs
csharp/src/ProtocolBuffersLite.Test/TestProtos/UnittestLite.cs