Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation does not include release version information #356

Closed
rgeary1 opened this issue May 10, 2015 · 2 comments
Closed

Documentation does not include release version information #356

rgeary1 opened this issue May 10, 2015 · 2 comments
Labels
bug documentation

Comments

@rgeary1
Copy link

rgeary1 commented May 10, 2015

The .proto documentation is now confusing - new language features like "map" have been added to proto2 and proto3 docs, but this feature is not available in the latest stable release (2.6.1). This is especially confusing given that it appears in "proto2" docs, which implies it's in the older version.

The documentation should include statements specifying the minimum version for each language feature, or at least add that information for "map".
@celskeggs
Copy link

I concur with this - I was very confused by proto2 not supporting maps when the documentation said that it should.

@liujisi
Copy link
Contributor

liujisi commented Mar 7, 2017

We had one discussion years ago and decide not to list version that the feature is added. Main rationale is for readability that the doc won't have versioning tags all over the place. Users should use the newest version instead. I guess we could have snapshot of docs for each version instead.

@liujisi liujisi closed this as completed Mar 7, 2017
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@cybrcodr @dsnet
Fixed broken tests on pre-go1.8 protocolbuffers#356 (protocolbuffers#359
63bfc70 
)

Disable benchmarks using testing.B.Run for pre-go1.7.

Fix unmarshaling Any for pre-1.8.  Unmarshaling code for Any assumed
json.RawMessage value receiver on json.Marshaler interface, but it was a
pointer receiver pre-1.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liujisi @rgeary1 @celskeggs @xfxyjwf