Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClsCompliant declarations from C# code (fix #318) #330

Merged
merged 1 commit into from May 1, 2015
Merged

Remove ClsCompliant declarations from C# code (fix #318) #330

merged 1 commit into from May 1, 2015

Conversation

anandolee
Copy link
Contributor

No description provided.

@anandolee
Copy link
Contributor Author

#318

@anandolee anandolee changed the title Remove ClsCompliant declarations from C# code #318 Remove ClsCompliant declarations from C# code (fix #318) May 1, 2015
@anandolee anandolee assigned anandolee and jskeet and unassigned anandolee and jskeet May 1, 2015
@anandolee
Copy link
Contributor Author

@jskeet @jtattermusch Please help to review

@jtattermusch
Copy link
Contributor

LGTM, but please squash the two commits into one, to maintain a more readable history.

git rebase -i upstream/csharp and then git push -f ....

@jskeet
Copy link
Contributor

jskeet commented May 1, 2015

Changes themselves LGTM (with a squash as Jan suggests) - I don't know the C++ codebase to know whether this is all that's required, but I trust you both on that :)

anandolee added a commit that referenced this pull request May 1, 2015
Remove ClsCompliant declarations from C# code (fix #318)
@anandolee anandolee merged commit e0afc00 into protocolbuffers:csharp May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants