Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using xUnit for all unit tests, and fetch that via NuGet. #324

Merged
merged 1 commit into from Apr 30, 2015

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Apr 30, 2015

This includes fetching the VS unit test runner package, so that tests can be run from Visual Studio's Test Explorer.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jskeet jskeet changed the title 2Change to using xUnit for all unit tests, and fetch that via NuGet. Change to using xUnit for all unit tests, and fetch that via NuGet. Apr 30, 2015
@googlebot
Copy link

CLAs look good, thanks!

@jskeet
Copy link
Contributor Author

jskeet commented Apr 30, 2015

I think this is now right. I managed to screw up my local repositories in all kinds of ways...

@jskeet
Copy link
Contributor Author

jskeet commented Apr 30, 2015

@jtattermusch to review - the changes are almost all of the form

  • [TestMethod] => [Fact]
  • Assert.AreEqual => Assert.Equal (etc)

... and converting lots of try/catch blocks to Assert.Throws

This includes fetching the VS unit test runner package, so that tests can be run from Visual Studio's Test Explorer.
@jtattermusch
Copy link
Contributor

LGTM.

jskeet added a commit that referenced this pull request Apr 30, 2015
Change to using xUnit for all unit tests, and fetch that via NuGet.
@jskeet jskeet merged commit 0884b77 into protocolbuffers:csharp Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants