Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating move constructors and operators using cpp_opt=cxx11 #316

Closed
wants to merge 0 commits into from

Conversation

romange
Copy link

@romange romange commented Apr 29, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@romange
Copy link
Author

romange commented Apr 29, 2015

I signed it!

On Wed, Apr 29, 2015 at 12:04 PM, googlebot notifications@github.com
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#316 (comment).

Best regards,
Roman

@googlebot
Copy link

CLAs look good, thanks!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 6, 2015

Thanks for the change, but we probably could not proceed with it before some internal issues are resolved. Internally there is a proposal to make protobuf's movable but so far the proposal has not been approved yet. Before that is resolved, we will not add any support for move semantics in the library.

@steve-lorimer
Copy link

+1

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@romange romange closed this Apr 11, 2016
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
* Regenerate

* Correct some mistakes

Most notable is the bug in (*proto.Properties).Parse, for which I've
added a test.

Found with honnef.co/go/tools/cmd/staticcheck.

	proto/properties.go:218:2: this value of s is never used (SA4006)
	proto/properties.go:329:5: ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
	protoc-gen-go/generator/generator.go:1686:5: this value of obj is never used (SA4006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants