Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Bazel support? #311

Closed
huahang opened this issue Apr 28, 2015 · 3 comments
Closed

Google Bazel support? #311

huahang opened this issue Apr 28, 2015 · 3 comments

Comments

@huahang
Copy link
Contributor

huahang commented Apr 28, 2015

The newly released bazel seems to be a very promising build tool. Can we add Google Bazel build for protobuf?

http://bazel.io/

Thanks,
Huahang
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 28, 2015

Seems it's the time to open-source the BUILD files we have been using internally for building protobufs :)

And just for the reference, an ex-googler has already written some BUILD files for protobuf here: https://github.com/mzhaom/trunk/tree/master/third_party/protobuf

@lshamis lshamis mentioned this issue May 4, 2015
Closed
@kjiwa
Copy link

kjiwa commented May 18, 2015

The bazel-examples repository has rules for building protoc: https://github.com/google/bazel-examples/tree/master/protobuf-2.5.0.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 8, 2015

There is a feature request for proto_library rule in bazel: bazelbuild/bazel#52

Before it's implemented in bazel, we can probably provide it as a wrapper script first.

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
taoso pushed a commit to taoso/protobuf that referenced this issue Aug 1, 2018
@dsnet
Remove raw interface (protocolbuffers#482)
7d76aa1 
There is an internal type to Google called RawMessage that is similar
to json.RawMessage. Since there is no proper proto reflection API,
we special-cased the Bytes method of RawMessage to access the raw bytes.
This is a gross hack since Bytes() []byte is such a common method signature.

Remove this hack.

Fixes protocolbuffers#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huahang @kjiwa @xfxyjwf