Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improper comment #301

Closed
craynic opened this issue Apr 23, 2015 · 3 comments
Closed

improper comment #301

craynic opened this issue Apr 23, 2015 · 3 comments

Comments

@craynic
Copy link

craynic commented Apr 23, 2015

src/google/protobuf/descriptor.proto:717721
these comment marks may cause compiling error.
I compile criu on Arch. criu comments some lines with /* and */, lines 717721 included, so I got a compiling error with lines after 721 not correctly commented.
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 23, 2015

I don't think this is a problem of the descriptor.proto. The code generator who generates code for descriptor.proto should be able to take care of such escaping.

@edmonds
Copy link
Contributor

edmonds commented Apr 23, 2015

criu is a C project, it uses protobuf-c, not protobuf. The original reporter's problem is due to a bug introduced in protobuf-c 1.1.0, fixed in protobuf-c 1.1.1. @xfxyjwf you can close this.

@craynic
Copy link
Author

craynic commented Apr 23, 2015

Sorry for bothering. I've sent out-of-date notice of protobuf-c to Arch.

@craynic craynic closed this as completed Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edmonds @craynic @xfxyjwf