Remove useless file that doesn't load #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, yes it looks like that is a remnant of the (now-deleted) v1 of the C++ extension! This should definitely be deleted. But I can't merge yet because it looks like this change breaks the build. Looks like this filename needs to be removed from one more place first: |
This file was broken in ada6556.
|
@haberman thanks! Should be good now |
|
@haberman green :) |
haberman
added a commit
that referenced
this pull request
Apr 8, 2015
Remove useless file that doesn't load
|
Thanks! |
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
)" This reverts commit e514ff5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was broken in ada6556.
@haberman this accounts for the problems I was seeing in #165.