Build scripts to publish precompiled protoc binaries (Maven-based) #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Cygwin with mingw gcc; build-protoc.sh works under Cygwin; build-protoc.sh will use the --host parameter consistent with what os-maven-plugin has detected
|
LGTM |
|
|
||
| ## Cross-compilation | ||
| The Maven script will try to detect the OS and the architecture from Java | ||
| system properties. It's possible to build a protoc binary for an arhitecture |
There was a problem hiding this comment.
s/arhitecture/architecture/
|
@zhangkun83, very nicely done. LGTM! |
liujisi
added a commit
that referenced
this pull request
Apr 2, 2015
Build scripts to publish precompiled protoc binaries (Maven-based)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local installation (
mvn install) works on Linux, Windows(Cygwin and MinGW), and Mac.@ejona86 @pherl please take a look.