Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance tests #267

Closed
wants to merge 3 commits into from
Closed

Conversation

haberman
Copy link
Member

@haberman haberman commented Apr 1, 2015

This is a resubmit of #172. I addressed the comments there.

@haberman
Copy link
Member Author

haberman commented Apr 1, 2015

To @xfxyjwf for continuation of previous review.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 1, 2015

Could you send this as a gerrit code review request? It's more like our internal code review tool and should be more convenient to work with large changes. Jisi has sent us instructions about how to use gerrit before.

@haberman
Copy link
Member Author

haberman commented Apr 2, 2015

Closing this in favor of the GerritHub review: https://review.gerrithub.io/#/c/229113/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants