Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant null pointer checks checks #260

Merged
merged 2 commits into from Feb 17, 2016
Merged

Removes redundant null pointer checks checks #260

merged 2 commits into from Feb 17, 2016

Conversation

ejsd1989
Copy link
Contributor

closes #242

Removed redundant checks for NULL, when it will already be handled by calling 'delete'

Removed the redundant check for NULL which is already correctly handled
by used the delete
Removed the redundant check for NULL which is already handled by using
delete
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@haberman
Copy link
Member

This change looks good but you need to sign the CLA before we can accept it. Please let me know if you want to move forward with this. Otherwise I'll have to close the PR. Thanks, Josh

@ejsd1989
Copy link
Contributor Author

Thanks for the reminder, I just updated my CLA.

On Tue, Feb 16, 2016 at 4:28 PM, Joshua Haberman notifications@github.com
wrote:

This change looks good but you need to sign the CLA before we can accept
it. Please let me know if you want to move forward with this. Otherwise
I'll have to close the PR. Thanks, Josh


Reply to this email directly or view it on GitHub
#260 (comment).

@googlebot
Copy link

CLAs look good, thanks!

@haberman
Copy link
Member

Thanks for contributing!

haberman added a commit that referenced this pull request Feb 17, 2016
Removes redundant null pointer checks checks
@haberman haberman merged commit d41db75 into protocolbuffers:master Feb 17, 2016
@elfring
Copy link

elfring commented Feb 17, 2016

Thanks for your small source code improvement.

bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Removes redundant null pointer checks checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary null pointer checks
4 participants