Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete "SEBS" (aka: Clean up Kenton's old trash) #257

Merged
merged 1 commit into from Mar 27, 2015
Merged

Delete "SEBS" (aka: Clean up Kenton's old trash) #257

merged 1 commit into from Mar 27, 2015

Conversation

kentonv
Copy link
Contributor

@kentonv kentonv commented Mar 27, 2015

The file SEBS is a build file for a toy build system I was writing in my spare time six years ago, back when I maintained protobufs. Arguably it was never appropriate for me to have placed this file in the protobuf tree, but it was convenient at the time and didn't seem to hurt anything. It clearly doesn't belong here now, though.

The file `SEBS` is a build file for a toy build system I was writing in my spare time six years ago, back when I maintained protobufs. Arguably it was never appropriate for me to have placed this file in the protobuf tree, but it was convenient at the time and didn't seem to hurt anything. It clearly doesn't belong here now, though.
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@kentonv
Copy link
Contributor Author

kentonv commented Mar 27, 2015

(CLA signed, though it's probably moot for a delete-only change.)

@googlebot
Copy link

CLAs look good, thanks!

haberman added a commit that referenced this pull request Mar 27, 2015
Delete "SEBS" (aka: Clean up Kenton's old trash)
@haberman haberman merged commit 86d9306 into protocolbuffers:master Mar 27, 2015
@haberman
Copy link
Member

Thanks Kenton!

@hzeller
Copy link
Contributor

hzeller commented Mar 27, 2015

I like the irony of Kenton having to sign the CLA :)

@cbsmith
Copy link

cbsmith commented Mar 27, 2015

That is pretty awesome.

On Fri, Mar 27, 2015 at 1:56 PM, Henner Zeller notifications@github.com
wrote:

I like the irony of Kenton having to sign the CLA :)


Reply to this email directly or view it on GitHub
#257 (comment).

Chris

@edmonds
Copy link
Contributor

edmonds commented Mar 27, 2015

@kentonv Hey, the fix for the "goto fail" bug was also a delete-only change ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants