Rewrite of C# protogen to C++ (initial version) #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore this, it should have gone against my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewritten version of C# protobuf ProtoGen project. It is not 100% clean yet and there's many TODOs, but it's a good starting point and when testing it with unittest.proto, it generates code that is 99% similar to the one generated by original ProtoGen.
Things worth mentioning:
-- Support for generating service stubs
-- I've got rid of CSharpOptions and put C# specific options directly into descriptor.proto (as it is done for other languages). This probably needs special attention of protobuf team more than anything else. It also breaks existing .proto files for C# users, because the C# options are now specified differently (Jon, can you comment on that?).
-- Most of things marked as TODO(jtattermusch) need to be resolved.