Add Objective C keywords to C++ keyword list #246
Conversation
| // OBJECTIVE C KEYWORDS AND MACROS | ||
| "__autoreleasing", "__strong", "__unsafe_unretained", "__weak", "id", "Class", | ||
| "_cmd", "BOOL", "BSD", "bycopy", "byref", "IMP", "In", "inout", "Nil", "nil", | ||
| "NO", "oneway", "out", "SEL", "self", "super", "YES" |
There was a problem hiding this comment.
This will likely to break existing clients, especially those all caps ones. I did a quick code search internally all the caps one are already being used as enum values: BOOL, BSD, YES, NO and SEL.
There was a problem hiding this comment.
Also checked lower-cased words: id, out, self, nil, oneway, super are also used as field names, which will break clients if we put them here.
There was a problem hiding this comment.
What if we put this behind a command line flag? --objc-compatible or some such?
There was a problem hiding this comment.
I'm a bit concerned that we will end up adding more and more keywords for other languages. There will be an official objective-c support release in a month or two. I think the need for linking in C++ messages should be significantly reduced.
There was a problem hiding this comment.
Ah, in that case we can probably just wait for the official support. If the obj c compiler doesn't already have a keyword list, you might want to use this. I don't see objective C in the source tree?
Many Objective C users rely on the C++ generated code to use protobufs in objective C.
See https://www.safaribooksonline.com/library/view/learning-objective-c-20/9780133047462/app01.html for a listing of keywords.