Make descriptor.proto compatible with stricter rules for comments in C #243
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
@googlebot: The contribution is too small to fall under copyright or patent rules. |
|
CLAs look good, thanks! |
|
I don't think this commit is right. The block comment delimiters are supposed to appear in output, e.g. https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/DescriptorProtos.SourceCodeInfo.LocationOrBuilder#hasLeadingComments(). |
|
Hm, protobuf-c copies these // comments straight into its output, which then upsets the C compiler ("/* within comment"). Do you see any way to circumvent that? |
|
Yes. This is a bug in protobuf-c 1.1.0 which was fixed in 1.1.1, which I released about an hour ago :-) |
Map parsing/serializing relies on map entries always having a predictable order. The code that generates layout was not respecting this in the case of string keys and primitive values.
No description provided.