Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #241

Closed
elfring opened this issue Mar 13, 2015 · 2 comments
Closed

reserved identifier violation #241

elfring opened this issue Mar 13, 2015 · 2 comments
Labels
c++ cleanup

Comments

@elfring
Copy link

elfring commented Mar 13, 2015

I would like to point out that identifiers like "GOOGLE_PROTOBUF_ARENA_H__" and "GOOGLE_PROTOBUF_SERVICE_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 13, 2015

Thanks for pointing this out! It seems our internal code base uses both two trailing underscores and one trailing underscore in these macros inconsistently. This needs to be cleaned up.

feyr666 added a commit to wolf34736/protobuf that referenced this issue Apr 16, 2015
@feyr666
solved issue protocolbuffers#241: reserved identifier violation
f3af2c1
@sahlberg
Copy link

This issue can be closed now ?

@gerben-s gerben-s closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sahlberg @elfring @gerben-s @xfxyjwf