Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct JavaDoc return value documentation for Parser#parseDelimitedFrom... #216

Merged
merged 1 commit into from Feb 26, 2015

Conversation

cnauroth
Copy link
Contributor

....

In Parser#parseDelimitedFrom, the JavaDoc states that the return value is true or false. This is incorrect, because the return type of the method is not boolean. Otherwise, the description of the behavior with respect to EOF is accurate. We can correct this by changing the text to mention that null is a possible return value.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@cnauroth
Copy link
Contributor Author

I just signed the CLA. Thanks!

@googlebot
Copy link

CLAs look good, thanks!

@liujisi
Copy link
Contributor

liujisi commented Feb 26, 2015

LGTM. Thanks!

liujisi added a commit that referenced this pull request Feb 26, 2015
Correct JavaDoc return value documentation for Parser#parseDelimitedFrom...
@liujisi liujisi merged commit 0e5fc48 into protocolbuffers:master Feb 26, 2015
@cnauroth
Copy link
Contributor Author

@pherl , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants