Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby implementation Map#inspect should be consistent with Hash#inspect #211

Merged
merged 1 commit into from Feb 17, 2015

Conversation

isaiah
Copy link
Contributor

@isaiah isaiah commented Feb 14, 2015

map = Google::Protobuf::Map.new
map["foo"]  = "bar"
map == {"foo" => "bar"}
# => true
# however
map.inspect
# => "{\"foo\" => \"bar\"}"
{"foo" => "bar"}.inspect
# => "{\"foo\"=>\"bar\"}"

I think it's better to conserve the consistency here.

@cfallin
Copy link
Contributor

cfallin commented Feb 17, 2015

Thanks!

cfallin added a commit that referenced this pull request Feb 17, 2015
Ruby implementation Map#inspect should be consistent with Hash#inspect
@cfallin cfallin merged commit db87a9c into protocolbuffers:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants