Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe generated code through clang-format when available #207

Closed
ctiller opened this issue Feb 12, 2015 · 1 comment
Closed

Pipe generated code through clang-format when available #207

ctiller opened this issue Feb 12, 2015 · 1 comment

Comments

@ctiller
Copy link
Contributor

ctiller commented Feb 12, 2015

To make it look a little prettier/easier to follow.

snkemp added a commit to wolf34736/protobuf that referenced this issue May 1, 2015
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jan 20, 2016

I think it's easy enough for users to run clang-format on the generated code themselves if they intend to read the code. Asking protoc to pipe its output through another binary is likely to make protoc more fragile and it also doesn't provide enough flexibility (like custom clang-format options users may want).

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants