Add missing LIBPROTOC_EXPORT to ruby generator #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfallin for review |
|
Thanks, @nsuke! Can you wrap the changed line at 80 columns? We'll be happy to merge after that. |
nsuke
force-pushed
the
protoc-export-ruby
branch
from
2a669d8
to
de525ec
Compare
|
Fixed the wrapping. |
cfallin
added a commit
that referenced
this pull request
Feb 8, 2015
Add missing LIBPROTOC_EXPORT to ruby generator
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…per the proto3 spec). This resolves protocolbuffers#197.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.