New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building protoc using MSVS projects doesn't work: Ruby-related link error. #184
Comments
Hi @vadz, I don't have access to Visual Studio at the moment, but could you copy/paste the errors you're seeing so that I have some idea of what we're looking at? Thanks! |
Here they are:
|
This is an issue caused by using PR #183 is addressing this issue. |
Looks like this was fixed a while ago. I'll close this for now -- please re-open if it is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the current (8ccaa42) sources, protoc doesn't link as the project doesn't include
ruby_generator.cc
butgoogle::protobuf::compiler::ruby::Generator
is unconditionally referenced inmain.cc
. Unfortunately fixing this is not as easy as just adding this file to the project as it doesn't compile with MSVS (tons of errors, didn't have time to really look at them and it was simpler to just disable Ruby generation for me).The text was updated successfully, but these errors were encountered: