Fix illegal C++ use of reinterpret_cast<> to cast between nullptr_t and a pointer #180
Conversation
|
This change looks good to me. It appears you haven't signed Google CLA though. Could you sign it following the link below? |
|
Signed. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
To be honest googlebot you're beginning to annoy me now. I use a different email for everything, it makes spam management much easier. The email in git commits is intentionally invalid, so I cannot add it to any CLA. |
|
Thanks for the change :) |
Fix illegal C++ use of reinterpret_cast<> to cast between nullptr_t and a pointer
Removed arena and reflective members like array type from upb_msg representation.
The present usage of reinterpret_cast to cast a nullptr_t to a pointer generates an illegal C++ hard error in clang. This is correct, as per http://en.cppreference.com/w/cpp/language/reinterpret_cast the reinterpret_cast cast may not cast nullptr_t to any other pointer. This pull request replaces the cast with static_cast, which is the legal form of cast to use.