Conformance tests for protobuf implementations. #172
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Review to @pherl . |
|
@xfxyjwf : do you want to offer any comments? Jisi said it looks basically ok. |
|
I remember we talked about adding these conformance test in a separate repository in the last team meeting. Is the plan changed and we are going to add them to this repository directly? |
|
I liked that idea, but Jisi suggested that it might be better to put them in the main repository. It would make it possible to run the conformance tests on your development tree without having to install the development code onto your system. That said I am open to either approach. We can move them to a separate repo later if desired. |
| NestedMessage oneof_nested_message = 112; | ||
| string oneof_string = 113; | ||
| bytes oneof_bytes = 114; | ||
| } |
This contains both a conformance test runner (usable against any protobuf implementation) and an implementation for protobuf C++.
This is just the beginning of the actual tests themselves, I'll be adding more rapidly.
The C++ implementation doesn't pass all of these tests right now, so I didn't want to make the tests part of Travis until they are all passing.