New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes related to the use with MS Visual Studio Compiler #171
Conversation
Additional security check (zero_copy_stream_impl.cc), Fix in protoc for MSVC: VC requires explicit declaration of constructor for struct $name$OneofInstance() (cpp_message.cc)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
I have signed CLA. |
CLAs look good, thanks! |
@@ -1217,6 +1217,11 @@ GenerateDescriptorDeclarations(io::Printer* printer) { | |||
} | |||
} | |||
|
|||
printer->Print("#ifdef _MSC_VER" "\n" | |||
" $name$OneofInstance() {}" "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would VC require a constructor? I tested v3.0.0-alpha-1 on visual studio 2008 and 2013 but did not find such a problem.
My bad that I used commit This issue:
was already fixed by this definition @ common.h:317
in commit by you Another issue:
was fixed by you, too The last issue (VS2008 error example below):
was fixed, but I still wondering why this was happening. So, my pull request became really short. Please excuse me for the inconvenience and not updating to the latest alpha release before commenting (too much work with lots of third-party libraries requires to think twice before updating to the latest release, that's why I had fixed issues with commit I checked out in November instead of keep tracking the development. Sorry.) P.S. I'm using VS2008 (cl.exe version 15.00.30729.01) and VS2013. |
Additional overflow check (zero_copy_stream_impl.cc)