Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Windows: VS2010+, x64 build option, test fixes #150

Closed
wants to merge 8 commits into from

Conversation

ricksladkey
Copy link

The Windows build is currently broken by unresolved externals for the ruby generator. This pull request fixes that problem and in addition updates the support for Windows to include recent versions of Visual Studio.

  • Support for VS2008 still present but renamed
  • Support for VS2010, VS2012, and VS2013 added
  • Support for Win32 and x64 platform configurations (32-bit and 64-bit)
  • Fixes so that all tests pass on Windows
  • Verified that a Linux build still passes "make check"

I will make a subsequent pull request to support the Python --cpp_implementation on Windows but those changes depend on the features in this pull request.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@ricksladkey
Copy link
Author

I've signed a CLA, which should now be on file.

@googlebot
Copy link

CLAs look good, thanks!

@liujisi
Copy link
Contributor

liujisi commented Feb 27, 2015

I tested VS2008 and VS2013 and all the test should pass. Do you know the ReadFileContent is causing problems on which environment?

@ricksladkey
Copy link
Author

@pherl It does indeed pass all the tests in tests.exe now in master. I'll close this PR.

Although these non-Unix project files are a hassle to maintain, it is necessary to build with the proper compiler in order the use the python --cpp-implementation to use with the standard python installers. The ideal long-term solution is a pypi wheel distribution that includes the necessary native modules compiled with the appropriate compiler.

For example, to use protobuf --cpp-implementation with the Windows 64-bit flavor of python 3.4 from python.org, the native protobuf module needs to be compiled with the VS2010 compiler and an x64 target.

bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants