New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Windows: VS2010+, x64 build option, test fixes #150
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
I've signed a CLA, which should now be on file. |
CLAs look good, thanks! |
071a7a7
to
92a402f
Compare
92a402f
to
7a7dc13
Compare
I tested VS2008 and VS2013 and all the test should pass. Do you know the ReadFileContent is causing problems on which environment? |
@pherl It does indeed pass all the tests in tests.exe now in master. I'll close this PR. Although these non-Unix project files are a hassle to maintain, it is necessary to build with the proper compiler in order the use the python For example, to use protobuf |
A few small API tweaks.
The Windows build is currently broken by unresolved externals for the ruby generator. This pull request fixes that problem and in addition updates the support for Windows to include recent versions of Visual Studio.
I will make a subsequent pull request to support the Python
--cpp_implementation
on Windows but those changes depend on the features in this pull request.