Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many methods in CodedInputStream are missing const qualifier #124

Closed
vlovich opened this issue Dec 8, 2014 · 1 comment
Closed

Many methods in CodedInputStream are missing const qualifier #124

vlovich opened this issue Dec 8, 2014 · 1 comment
Labels
c++ wontfix

Comments

@vlovich
Copy link

vlovich commented Dec 8, 2014

Public methods missing const qualification, at least. Could be others + other private functions that could/should be marked const.

ConsumedEntireMessage
GetDirectBufferPointerInline
BytesUntilLimit
LastTagWas
ExpectTagFromArray
@vlovich vlovich changed the title Many methods in CodedInputStream aren't properly const-qualified Many methods in CodedInputStream are missing const qualifier Dec 8, 2014
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jan 20, 2016

As an IO stream class, it doesn't seem useful to have these methods marked as const even if they don't mutate the stream's state.

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
@haberman
Merge pull request protocolbuffers#124 from haberman/unknown
b2a3882 
Added support for unknown fields to upb_msg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlovich @xfxyjwf