Make ByteStrings serializable with java serialization. #102
Conversation
| @@ -393,4 +396,17 @@ public void testConcat_empty() { | |||
| assertSame("empty concatenated with " + classUnderTest + " must give " + classUnderTest, | |||
| ByteString.EMPTY.concat(stringUnderTest), stringUnderTest); | |||
| } | |||
|
|
|||
| public void testJavaSerialization() throws Exception { | |||
There was a problem hiding this comment.
Can you add this test for BoundedByteString and RopeByteString as well?
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Confirmed. Both fizbin@gmail.com and daniel.martin@crowdstrike.com are the same person (me). |
|
If it would be more convenient for me to close this request and reopen it with commits all authored by the same email address, let me know. |
|
I think it's fine. Thanks for the patch. |
Make ByteStrings serializable with java serialization.
Added google/protobuf/descriptor.upb.* to core.
Added google/protobuf/descriptor.upb.* to core.
Make ByteStrings serializable with java serialization.
Fixes https://code.google.com/p/protobuf/issues/detail?id=485