Decouple platform-related stuff from Graphics #11
+78
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Graphics elegantly and even use Graphics alone as a rendering engine without touching the platform
|
Hi, Michael, What do you think about this pull request? |
|
I think it's the middle of PAX! :) I'll look at it tomorrow because I'm going to be on the floor all day today. The general idea doesn't sound bad to me, I just need to see how much weirding was necessary to make it all work. I'd prefer not to make the normal use case too weird to accommodate this 0.1% use case. I'm sure that can be accomplished somehow. |
|
Glad to hear that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working a project in which we need to replay the game and record it into video on every platform, in which case, it's really not necessary to load the whole platform and Graphics is good enough. In addition, the graphic related configuration is all platform specific graphics need.
This commit will cause code breaks for registering additional fonts on specific platforms. Those can be easily fixed by calling the plat.assets().getFont() or equivalent methods on specific platforms.