You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What steps will reproduce the problem?
1. Try to connect irc server with a password.
What is the expected output? What do you see instead?
PASS message should be sent to the server, but it wasn't.
I read source codes and found a mistake in PircBotX.java.
line: 329-331
// Attempt to join the server.
if (Utils.isBlank(password))
_outputThread.sendRawLineNow("PASS " + password);
should be
// Attempt to join the server.
if (!Utils.isBlank(password))
_outputThread.sendRawLineNow("PASS " + password);
What version of the product are you using? On what operating system?
Version 1.3 Beta 2
with Jenkins IRC Plugin v2.15
Please provide any additional information below.
I used Jenkins IRC Plugin and tried to connect my irc server.
But IRC bot couldn't connect the server and the Jenkins logs showed "Passoword
incorrect" message.
Original issue reported on code.google.com by kami...@gmail.com on 1 Jul 2011 at 3:46
The text was updated successfully, but these errors were encountered:
Thanks for pointing that out. I'm currently out of town, but I should be able
to get that into the latest SNAPSHOT by Tuesday.
With the test, I think its time I wrote some test for stuff the bot sends
instead of just what it receives. Thanks for the mockito code, it will really
help.
Original comment by Lord.Qua...@gmail.com on 4 Jul 2011 at 4:13
This was fixed in Revision e3fd86c6c4e7. Big thanks for the example mockito
code, its going to be very useful in other tests. I added a slightly modified
version of your code in Revision: 58e7c245bd83.
Note that there isn't a new snapshot out yet as I still need to fix an
unrelated issue. It should be out by tomorrow.
Original comment by Lord.Qua...@gmail.com on 6 Jul 2011 at 3:13
Original issue reported on code.google.com by
kami...@gmail.com
on 1 Jul 2011 at 3:46The text was updated successfully, but these errors were encountered: