Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASS message is not sent to a server #29

Closed
GoogleCodeExporter opened this issue Apr 23, 2015 · 3 comments
Closed

PASS message is not sent to a server #29

GoogleCodeExporter opened this issue Apr 23, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Try to connect irc server with a password.

What is the expected output? What do you see instead?
PASS message should be sent to the server, but it wasn't.

I read source codes and found a mistake in PircBotX.java.

line: 329-331
// Attempt to join the server.
if (Utils.isBlank(password))
    _outputThread.sendRawLineNow("PASS " + password);

should be

// Attempt to join the server.
if (!Utils.isBlank(password))
    _outputThread.sendRawLineNow("PASS " + password);


What version of the product are you using? On what operating system?
Version 1.3 Beta 2
with Jenkins IRC Plugin v2.15

Please provide any additional information below.

I used Jenkins IRC Plugin and tried to connect my irc server.
But IRC bot couldn't connect the server and the Jenkins logs showed "Passoword 
incorrect" message.

Original issue reported on code.google.com by kami...@gmail.com on 1 Jul 2011 at 3:46

@GoogleCodeExporter
Copy link
Author

I've wrote a patch and a test.

Original comment by kato.kaz...@gmail.com on 4 Jul 2011 at 3:45

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for pointing that out. I'm currently out of town, but I should be able 
to get that into the latest SNAPSHOT by Tuesday.

With the test, I think its time I wrote some test for stuff the bot sends 
instead of just what it receives. Thanks for the mockito code, it will really 
help.

Original comment by Lord.Qua...@gmail.com on 4 Jul 2011 at 4:13

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

This was fixed in Revision e3fd86c6c4e7. Big thanks for the example mockito 
code, its going to be very useful in other tests. I added a slightly modified 
version of your code in Revision: 58e7c245bd83.

Note that there isn't a new snapshot out yet as I still need to fix an 
unrelated issue. It should be out by tomorrow. 

Original comment by Lord.Qua...@gmail.com on 6 Jul 2011 at 3:13

  • Changed state: Fixed

@TheLQ TheLQ added bug and removed Type-Defect labels Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants