My favorites | Sign in
Logo
                
Revision: r2198
Author:  Jake.Stine
Date:  Nov 14, 2009
Review scores:
+1 
 
Positive:
arcum42
 

Log message

Mode console logging updates and additions;
 * Added support for indentation, as a replacement for using \t  (options
include methods SetIndent and Indent, and a ConsoleIndentScope class for scoped
indentation of a block of WriteLns.)
 * Use of Indent() as a modifier (the abstraction optionally allows use of
indentation methods besides \t, if ever needed).
 * Minor header file cleanups: wxWidgets standard headers are now always first
in PrecompiledHeader.h files (is recommended due to cross platform setup code by
wx).

Affected files

    expand all   collapse all
Modify/trunk/3rdparty/wxWidgets/build/msw/wx_config_2008.vcprojdiff
Modify/trunk/common/build/x86emitter/x86emitter.vcprojdiff
Modify/trunk/common/include/Utilities/Console.hdiff
Modify/trunk/common/include/Utilities/Dependencies.hdiff
Modify/trunk/common/include/Utilities/pxRadioPanel.hdiff
Modify/trunk/common/src/Utilities/Console.cppdiff
Modify/trunk/common/src/Utilities/PrecompiledHeader.hdiff
Modify/trunk/common/src/x86emitter/PrecompiledHeader.hdiff
Modify/trunk/pcsx2/CDVD/CDVD.cppdiff
Modify/trunk/pcsx2/CDVD/CDVDisoReader.cppdiff
Modify/trunk/pcsx2/Memory.cppdiff
Modify/trunk/pcsx2/Patch.cppdiff
Modify/trunk/pcsx2/PluginManager.cppdiff
Modify/trunk/pcsx2/RecoverySystem.cppdiff
Modify/trunk/pcsx2/SaveState.cppdiff
Modify/trunk/pcsx2/System.cppdiff
Modify/trunk/pcsx2/gui/AppInit.cppdiff
Modify/trunk/pcsx2/gui/ConsoleLogger.cppdiff
Modify/trunk/pcsx2/gui/ConsoleLogger.hdiff
Modify/trunk/pcsx2/gui/IniInterface.cppdiff
Modify/trunk/pcsx2/gui/i18n.cppdiff
Modify/trunk/pcsx2/windows/VCprojects/pcsx2_2008.vcprojdiff
Modify/trunk/pcsx2/x86/sVU_zerorec.cppdiff
Comment by Jake.Stine, Nov 14, 2009
I'm "mostly" happy with this.  There's probably room for improvement .. tho when isn't there? ;)

I could have also used a \t replacement parser instead of the Indent() approach.  \t is more compact I suppose, though it wouldn't have allowed for scope-based tabbing.

Sign in to write a code review
Hosted by Google Code