My favorites | Sign in
Logo
                
Revision: r2197
Author:  arcum42
Date:  Nov 14, 2009
Review scores:
+2 
 
Positive:
andutrache,
Jake.Stine
 

Log message

Trim and tweak a bunch of includes, and a few headers.

Affected files

    expand all   collapse all

This revision affected a large number of files. Only a subset of 50 changed paths are being shown. To see all changed paths, use the svn log command-line.

Modify/trunk/pcsx2/CDVD/CDVD.cppdiff
Modify/trunk/pcsx2/CDVD/CDVDaccess.cppdiff
Modify/trunk/pcsx2/CDVD/CDVDisoReader.cppdiff
Modify/trunk/pcsx2/CDVD/CdRom.cppdiff
Modify/trunk/pcsx2/CDVD/IsoFS/IsoFS.cppdiff
Modify/trunk/pcsx2/CDVD/IsoFS/IsoFSCDVD.cppdiff
Modify/trunk/pcsx2/CDVD/IsoFS/IsoFile.cppdiff
Modify/trunk/pcsx2/CDVD/IsoFileFormats.cppdiff
Modify/trunk/pcsx2/COP0.cppdiff
Modify/trunk/pcsx2/COP2.cppdiff
Modify/trunk/pcsx2/Cache.cppdiff
Modify/trunk/pcsx2/Common.hdiff
Modify/trunk/pcsx2/Counters.cppdiff
Modify/trunk/pcsx2/Dump.cppdiff
Modify/trunk/pcsx2/Elfheader.cppdiff
Modify/trunk/pcsx2/FPU.cppdiff
Modify/trunk/pcsx2/FiFo.cppdiff
Modify/trunk/pcsx2/GS.cppdiff
Modify/trunk/pcsx2/GSState.cppdiff
Modify/trunk/pcsx2/Gif.cppdiff
Add/trunk/pcsx2/Hardware.hdiff
Modify/trunk/pcsx2/Hw.cppdiff
Modify/trunk/pcsx2/HwRead.cppdiff
Modify/trunk/pcsx2/HwWrite.cppdiff
Modify/trunk/pcsx2/IPU/IPU.cppdiff
Modify/trunk/pcsx2/Interpreter.cppdiff
Modify/trunk/pcsx2/IopBios.cppdiff
Modify/trunk/pcsx2/IopCommon.hdiff
Modify/trunk/pcsx2/IopCounters.cppdiff
Modify/trunk/pcsx2/IopDma.cppdiff
Modify/trunk/pcsx2/IopHw.cppdiff
Modify/trunk/pcsx2/IopSio2.cppdiff
Modify/trunk/pcsx2/Linux/pcsx2.cbpdiff
Modify/trunk/pcsx2/MMI.cppdiff
Modify/trunk/pcsx2/MTGS.cppdiff
Modify/trunk/pcsx2/Memory.cppdiff
Modify/trunk/pcsx2/Pcsx2Config.cppdiff
Modify/trunk/pcsx2/PluginManager.cppdiff
Modify/trunk/pcsx2/R3000A.cppdiff
Modify/trunk/pcsx2/R3000AInterpreter.cppdiff
Modify/trunk/pcsx2/R3000AOpcodeTables.cppdiff
Modify/trunk/pcsx2/R5900.cppdiff
Modify/trunk/pcsx2/R5900OpcodeImpl.cppdiff
Modify/trunk/pcsx2/R5900OpcodeTables.cppdiff
Modify/trunk/pcsx2/RecoverySystem.cppdiff
Modify/trunk/pcsx2/SPR.cppdiff
Modify/trunk/pcsx2/SaveState.cppdiff
Modify/trunk/pcsx2/Sif.cppdiff
Modify/trunk/pcsx2/Sio.cppdiff
Modify/trunk/pcsx2/System.cppdiff
Comment by arcum42, Nov 14, 2009
I'll check this in a few minutes against Windows.
Comment by arcum42, Nov 14, 2009
Compiles a Devel build successfully. Now I'm doublechecking release.

Basically, what I did in this commit was I tweaked Common.h and IopCommon.h, removing a few includes, added a new header, Hardware.h, and went through deleting a bunch of unnecessary includes all over the place.
Comment by arcum42, Nov 14, 2009
Release build's fine too, btw.
Comment by andutrache, Nov 14, 2009
Cant buil this rev it gives me Error	1	Error result 31 returned from 'C:\Program Files\Microsoft SDKs\Windows\v6.0A\bin\mt.exe'.	Project	pcsx2
Comment by andutrache, Nov 14, 2009
build* damn no edit button
Comment by andutrache, Nov 14, 2009
ok an exe shows up even with this error but when i try running it its says MSVCP90.dll is missing what am i doing wrong all was working fine till now and i didn't change anything.
Comment by Jake.Stine, Nov 14, 2009
run clean_msvc.cmd and try again.
Comment by andutrache, Nov 14, 2009
that fixed it thank you :)

Sign in to write a code review
Hosted by Google Code