My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 19: Critical hits vor PvP
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Mar 2012


 
Reported by spoilerh...@gmail.com, Nov 6, 2011
Process critical hits in PvP: (pvB and PvC are probably similar)

-- combat_svs.js.bak   2011-11-06 11:04:04.000000000 +0100
+++ combat_svs.js       2011-11-06 11:13:32.000000000 +0100
@@ -165,9 +165,20 @@ while (cr[i] != 'E' && cr[i] != 'L') {
     i = i + 2;
     hits1[round-2] = "";
     while (cr[i] != "S2" && cr[i] != 'E' && cr[i] != 'L') {
-        hits1[round-2] += "<font color='green'>Hit with " + w1[cr[i]] + " for: " + cr[i+1] + "</font><br>";
+       var hitStr = "Hit";
+        var dmgStr = cr[i+1];
+        if (dmgStr == 'J') {
+            i = i + 2;
+            continue;
+        }
+        if (dmgStr.charAt(0) == 'C') {
+            hitStr = "<b>Critical Hit</b>";
+            dmgStr = dmgStr.substr(1);
+        }
+        hits1[round-2] += "<font color='green'>" + hitStr + " with " + w1[cr[i]] + " for: " + dmgStr + "</font><br>";
+
         wstats1[cr[i]]["hits"]++;
-        damages = extractDamage(cr[i+1]);
+        damages = extractDamage(dmgStr);
         wstats1[cr[i]]["hull"] += parseInt(damages["hull"]);
         wstats1[cr[i]]["armor"] += parseInt(damages["armor"]);
         wstats1[cr[i]]["shield"] += parseInt(damages["shield"]);
@@ -178,9 +189,20 @@ while (cr[i] != 'E' && cr[i] != 'L') {
     i++;
     hits2[round-2] = "";
     while (cr[i] != 'R' + round && cr[i] != 'E' && cr[i] != 'L') {
-        hits2[round-2] += "<font color='green'>Hit with " + w2[cr[i]] + " for: " + cr[i+1] + "</font><br>";
+       var hitStr = "Hit";
+        var dmgStr = cr[i+1];
+        if (dmgStr == 'J') {
+            i = i + 2;
+            continue;
+        }
+        if (dmgStr.charAt(0) == 'C') {
+            hitStr = "<b>Critical Hit</b>";
+            dmgStr = dmgStr.substr(1);
+        }
+        hits2[round-2] += "<font color='green'>" + hitStr + " with " + w2[cr[i]] + " for: " + dmgStr + "</font><br>";
+
         wstats2[cr[i]]["hits"]++;
-        damages = extractDamage(cr[i+1]);
+        damages = extractDamage(dmgStr);
         wstats2[cr[i]]["hull"] += parseInt(damages["hull"]);
         wstats2[cr[i]]["armor"] += parseInt(damages["armor"]);
         wstats2[cr[i]]["shield"] += parseInt(damages["shield"]);

Mar 11, 2012
Project Member #1 uncledan74
Fix seems already in 1.6.8 (thanks Bsg)
Status: Fixed

Powered by Google Project Hosting