From frederic...@gmail.com on May 29, 2013 07:00:01

I wrote a method to combine properties over super properties (see attached file).

In case you don't think it is appropriate to modify combinedQuantifiedPropertyPair, could I kindly request the following changes to keep using my own method?

• could combinedQuantifiedPropertyPair be made public?
• could getSuperPropertyClosureOf return a LinkedHashSet raster than a Set, so that super properties are ordered from the more precise one to the more general one?
• could getSuperPropertyReflexiveClosureOf return a LinkedHashSet raster than a Set, where the source property is the first element, not the last one?
• In getOWLGraphEdgeSubsumers, there is a piece of code useful when creating a new OWLQuantifiedProperty. Could you externalize that code in a public method?

if (pe.equals(this.getDataFactory().getOWLTopObjectProperty()))
continue;
if (pe instanceof OWLObjectProperty) {
OWLQuantifiedProperty newQp = new OWLQuantifiedProperty(pe, qp.getQuantifier());
if (!isExcluded(newQp)) {
superQps.add(newQp);
}
}

• or alternatively, could you make public the method isExcluded?

Thanks a lot, let me know what you think.

Attachment: combine.java

From frederic...@gmail.com on November 20, 2013 12:45:27

The class owltools.graph.OWLGraphWrapperEdgesExtended now implements these features.

Status: Fixed