Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line version produces strange file names when the source ontology is not in current directory #20

Closed
ShahimEssaid opened this issue Feb 2, 2015 · 4 comments

Comments

@ShahimEssaid
Copy link

From Sebastia...@charite.de on December 02, 2011 01:18:38

What steps will reproduce the problem?

  1. Start the command line version on an ontology file that is not located in the current directory.

    For instance:

    > bin/ontology-release-runner ../../../ontology/human-phenotype-ontology.obo

    produces files such as "..%2F..%2F..%2Fontology%2Fhuman-phenotype-ontology-merged.obo" in the current directory. This is under Linux. Apparently there is some URL transformation going on.

    I would expect that by default all output is placed within the current working directory with proper names.

Original issue: http://code.google.com/p/owltools/issues/detail?id=20

@ShahimEssaid
Copy link
Author

From HDie...@lbl.gov on December 02, 2011 16:38:53

The strange file names are generated, due to the fact, that there is no ontology id present in the source file.
It is strongly recommended to have an ontology id. The ontology id is specified in the ontology header using the 'ontology' tag. (For more details, please see the OBOFormat documentation http://www.geneontology.org/GO.format.obo-1_4.shtml#S.2.1 )

The output file name is generated using the ontology. If not present the path is used to generate an ID, which result in this strange file name.

Status: WontFix

@ShahimEssaid
Copy link
Author

From Sebastia...@charite.de on December 03, 2011 00:59:45

While appreciate this comment, please notice that this tag is new for OBO 1.4 as far as I can see it and even there it is not declared as required (only as should). In absence of this tag, I suggest to take only the last component of the path as the ontology when operating on a local filesystem, otherwise the tool behaves differently than many other build tools (e.g., gcc).

@ShahimEssaid
Copy link
Author

From HDie...@lbl.gov on December 05, 2011 17:43:00

Implemented suggested change. Now OORT checks the file name (if available) and removes the '.obo' or '.owl' suffix to create a default ontology id (committed in revision 394 ).

Status: Started

@ShahimEssaid
Copy link
Author

From HDie...@lbl.gov on January 12, 2012 15:32:59

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant