Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPParameterValue #338

Closed
meg23 opened this issue Nov 13, 2014 · 3 comments
Closed

HTTPParameterValue #338

meg23 opened this issue Nov 13, 2014 · 3 comments

Comments

@meg23
Copy link

meg23 commented Nov 13, 2014

From parashar...@gmail.com on August 27, 2014 00:30:51

I need to allow alphanumeric, new line, \t\n\r, single space and all special character except (< > double space)

What would be the excepted expression for configure Validator.HTTPParameterValue.

Ex. "02-Aug-2014 at 21:05#%#%&#1";

Original issue: http://code.google.com/p/owasp-esapi-java/issues/detail?id=335

@xeno6696
Copy link
Collaborator

Allowing the characters '\r\n' by themselves introduces the vulnerability of HTTP Header injection. Recommend the implementer URI-encode header values as opposed to opening a security flaw via regex.

@xeno6696
Copy link
Collaborator

@kwwall This issue should be closed.

@kwwall
Copy link
Contributor

kwwall commented Jan 10, 2016

Allowing this would allow HTTP Response Splitting vulnerabilities as well as violating the HTTP 1.1 spec (RFC 2616). Since ESAPI is supposed to be a security library, we are not going to make changes that intentionally facilitate attacks. The Validator.HTTPParameterValue regular expression in ESAPI.properties file can be altered to accept this if you really want to shoot yourself in the foot. (Just change it to '.*'. That will do it and more!)

This "bug" will NOT be fixed (it's really NOT a bug). Closing the issue.

@kwwall kwwall closed this as completed Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants