Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESAPI validator isValidRedirectLocation does not work #295

Closed
meg23 opened this issue Nov 13, 2014 · 1 comment
Closed

ESAPI validator isValidRedirectLocation does not work #295

meg23 opened this issue Nov 13, 2014 · 1 comment

Comments

@meg23
Copy link

meg23 commented Nov 13, 2014

From majorpe...@gmail.com on October 26, 2012 06:22:49

What steps will reproduce the problem? 1. Have a simple code that does an isValidRedirectLocation check What is the expected output? What do you see instead? The test will almost always fail, simply because the built-in Redirect pattern is defined as:
Validator.Redirect=^/test.*$
Could this be enhanced, so instead a real regexp is used? What version of the product are you using? On what operating system? Does not matter Does this issue affect only a specified browser or set of browsers? No Please provide any additional information below. Since the SecurityWrapperResponse is using the Redirect matching rule as well, probably that fails 99% of the cases as well.

Is using "URL" instead of "Redirect" a valid workaround?

Original issue: http://code.google.com/p/owasp-esapi-java/issues/detail?id=289

@xeno6696
Copy link
Collaborator

That regex is a secure default value, because it is doubtful that Validator.Redirect should ever direct to a "test" URL in a production environment. That property in particular, needs to be configured uniquely for your application. If it were me, I might even make that default regex one that wouldn't compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants