Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferencesFragement #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jakobmoellers
Copy link
Contributor

I suggest a version where I migrated from PreferencesActivity to PreferencesFragment to get rid of "deprecated" issues. Otherwise, findPreferences() always shows a deprecatedWarning for Honeycomb and higher.

@jakobmoellers
Copy link
Contributor Author

Just found out that the API level 7 that you want to support will not work with this solution...

@jakobmoellers
Copy link
Contributor Author

Mh strange, now it nevertheless compiles... maybe the support libraries are now used...

@jakobmoellers jakobmoellers reopened this Aug 14, 2013
@nguillaumin
Copy link
Contributor

Thanks for this pull request. Sounds good to me except that you used spaces instead of tabs in the source files. Would you be able to replace them with tabs to be consistent with the existing code? Thanks.

@nguillaumin
Copy link
Contributor

I just realized that some other files have a mix of tabs and space, presumably from patches from other contributors. I'll fix those as well.

@nguillaumin
Copy link
Contributor

I tested this one but with the SDK level 7 it doesn't work, I get java.lang.NoSuchMethodError: me.guillaumin.android.osmtracker.activity.SetPreferenceActivity.getFragmentManager. It seems that this method has been introduced in the level 11 of the SDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants