Record trackpoints after runtime GPS permission is granted during track recording. Fixes issue #207 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck recording. Fixes issue labexp#207
|
Hi, thanks for helping to improve the app, in fact this issue is very annoying and needs to be fixed as soon as possible. However we think that no re-registering or broadcasts would be needed if we just ask for GPS permission before even starting the TrackLogger activity this PR employs this strategy and also fixes the issue #207 . |
xsaco07
reviewed
Jun 25, 2019
There was a problem hiding this comment.
Thanks for the contribution @jdmonin , indeed as @EmmanuelAB says, this solution seems to be fine but is a little bit complicated.
We support the idea of asking for permissions before the activity and if are not granted just do not allow the user to continue.
The PR #208 solves this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #207. Tested on emulator and android 9 device with all of these scenarios: