Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find zlib.h #35

Closed
Steelskin opened this issue Sep 19, 2014 · 0 comments
Closed

Can't find zlib.h #35

Steelskin opened this issue Sep 19, 2014 · 0 comments

Comments

@Steelskin
Copy link
Contributor

Original issue 35 created by jbeder on 2012-04-30T20:43:23.000Z:

What steps will reproduce the problem?

  1. Download open-vcdiff-0.8.3.tar.gz
  2. Open vsprojects/open-vcdiff.sln in Visual Studio 2010
  3. Allow it to upgrade the solution file
  4. Build all

What is the expected output? What do you see instead?

It can't find the header file zlib.h.

If you add, in each project, the include directory "../../src/zlib", then it builds correctly.

What version of the product are you using? On what operating system?

Open vcdiff 0.8.3
Visual Studio 2010
Windows 7
Please provide any additional information below.

@Steelskin Steelskin self-assigned this Sep 19, 2014
Steelskin pushed a commit that referenced this issue Sep 19, 2014
  Release version 0.8.4 with the following changes:
  * Issue #35: Add "src/zlib" to the list of additional include directories
    when compiling open-vcdiff with Visual Studio.  This addresses a
    regression introduced in version 0.8.3.
  * Issues #36 and #37: Don't use trailing commas in JSON encoding.  Add a
    check for non-ASCII characters when using JSON format.  Cast char to
    unsigned char when testing whether its value is >= 0x80.
  * Issue #40: Avoid working with negative source offsets if the source data is
    small enough that it does not contain any blocks to hash.
  * Issue #41: Set GTEST_HAS_TR1_TUPLE to 0 so that it excludes
    (unused) std::tuple support when compiling gtest.
    According to the bug, <tr1/tuple> is not available on OS X.
  * Issue #42: Use unique_ptr (if available) instead of auto_ptr.
  * Issue #43: Remove a newline from Makefile.am to fix a reported
    incompatibility with openembedded framework and autoreconf.
  * Fix unused-local-typedefs warnings in GCC 4.7+ by marking the CompileAssert
    typedefs with __attribute__((unused)).
  * Remove unnecessary methods CodeTableWriterInterface::target_length() and
    VCDiffEngine::FinishEncoding().
  * Add the FALLTHROUGH_INTENDED macro to indicate that the lack of a "break;"
    at the end of a case in a switch statement is intentional.
  * Fix the comment for VCDiffFileBasedCoder::OpenFileForReading().
Steelskin pushed a commit that referenced this issue Sep 19, 2014
  Release version 0.8.4 with the following changes:
  * Issue #35: Add "src/zlib" to the list of additional include directories
    when compiling open-vcdiff with Visual Studio.  This addresses a
    regression introduced in version 0.8.3.
  * Issues #36 and #37: Don't use trailing commas in JSON encoding.  Add a
    check for non-ASCII characters when using JSON format.  Cast char to
    unsigned char when testing whether its value is >= 0x80.
  * Issue #40: Avoid working with negative source offsets if the source data is
    small enough that it does not contain any blocks to hash.
  * Issue #41: Set GTEST_HAS_TR1_TUPLE to 0 so that it excludes
    (unused) std::tuple support when compiling gtest.
    According to the bug, <tr1/tuple> is not available on OS X.
  * Issue #42: Use unique_ptr (if available) instead of auto_ptr.
  * Issue #43: Remove a newline from Makefile.am to fix a reported
    incompatibility with openembedded framework and autoreconf.
  * Fix unused-local-typedefs warnings in GCC 4.7+ by marking the CompileAssert
    typedefs with __attribute__((unused)).
  * Remove unnecessary methods CodeTableWriterInterface::target_length() and
    VCDiffEngine::FinishEncoding().
  * Add the FALLTHROUGH_INTENDED macro to indicate that the lack of a "break;"
    at the end of a case in a switch statement is intentional.
  * Fix the comment for VCDiffFileBasedCoder::OpenFileForReading().
Steelskin pushed a commit that referenced this issue Sep 19, 2014
  Release version 0.8.4 with the following changes:
  * Issue #35: Add "src/zlib" to the list of additional include directories
    when compiling open-vcdiff with Visual Studio.  This addresses a
    regression introduced in version 0.8.3.
  * Issues #36 and #37: Don't use trailing commas in JSON encoding.  Add a
    check for non-ASCII characters when using JSON format.  Cast char to
    unsigned char when testing whether its value is >= 0x80.
  * Issue #40: Avoid working with negative source offsets if the source data is
    small enough that it does not contain any blocks to hash.
  * Issue #41: Set GTEST_HAS_TR1_TUPLE to 0 so that it excludes
    (unused) std::tuple support when compiling gtest.
    According to the bug, <tr1/tuple> is not available on OS X.
  * Issue #42: Use unique_ptr (if available) instead of auto_ptr.
  * Issue #43: Remove a newline from Makefile.am to fix a reported
    incompatibility with openembedded framework and autoreconf.
  * Fix unused-local-typedefs warnings in GCC 4.7+ by marking the CompileAssert
    typedefs with __attribute__((unused)).
  * Remove unnecessary methods CodeTableWriterInterface::target_length() and
    VCDiffEngine::FinishEncoding().
  * Add the FALLTHROUGH_INTENDED macro to indicate that the lack of a "break;"
    at the end of a case in a switch statement is intentional.
  * Fix the comment for VCDiffFileBasedCoder::OpenFileForReading().
Steelskin pushed a commit that referenced this issue Sep 19, 2014
  Release version 0.8.4 with the following changes:
  * Issue #35: Add "src/zlib" to the list of additional include directories
    when compiling open-vcdiff with Visual Studio.  This addresses a
    regression introduced in version 0.8.3.
  * Issues #36 and #37: Don't use trailing commas in JSON encoding.  Add a
    check for non-ASCII characters when using JSON format.  Cast char to
    unsigned char when testing whether its value is >= 0x80.
  * Issue #40: Avoid working with negative source offsets if the source data is
    small enough that it does not contain any blocks to hash.
  * Issue #41: Set GTEST_HAS_TR1_TUPLE to 0 so that it excludes
    (unused) std::tuple support when compiling gtest.
    According to the bug, <tr1/tuple> is not available on OS X.
  * Issue #42: Use unique_ptr (if available) instead of auto_ptr.
  * Issue #43: Remove a newline from Makefile.am to fix a reported
    incompatibility with openembedded framework and autoreconf.
  * Fix unused-local-typedefs warnings in GCC 4.7+ by marking the CompileAssert
    typedefs with __attribute__((unused)).
  * Remove unnecessary methods CodeTableWriterInterface::target_length() and
    VCDiffEngine::FinishEncoding().
  * Add the FALLTHROUGH_INTENDED macro to indicate that the lack of a "break;"
    at the end of a case in a switch statement is intentional.
  * Fix the comment for VCDiffFileBasedCoder::OpenFileForReading().
@Steelskin Steelskin removed their assignment Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant