Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a log handler to log errors. #33

Open
Steelskin opened this issue Sep 19, 2014 · 2 comments
Open

Provide a log handler to log errors. #33

Steelskin opened this issue Sep 19, 2014 · 2 comments
Labels
enhancement Priority-High

Comments

@Steelskin
Copy link
Contributor

Original issue 33 created by thakis@google.com on 2011-12-09T03:58:01.000Z:

#include <iostream> introduces static initializers, see http://crbug.com/94794

open-vcdiff logs through cerr. If open-vcdiff must log, it should use fprintf(stderr, ...) – or, probably better, provide a log handler that embedders could override to do what they please.
@Steelskin Steelskin self-assigned this Sep 19, 2014
@Steelskin Steelskin added bug and removed Type-Defect labels Jul 15, 2015
@Steelskin Steelskin removed their assignment Jul 15, 2015
@Steelskin Steelskin mentioned this issue Jul 17, 2015
Closed
@Steelskin
Copy link
Contributor Author

Nothing very important in the old comments.
Increasing priority, this would allow open-vcdiff to work nicer with chromium for instance.

@Steelskin Steelskin changed the title open-vcdiff shouldn't log using cerr Provide a log handler to log errors. Jul 17, 2015
@Steelskin Steelskin added enhancement and removed bug labels Jul 17, 2015
@nico
Copy link
Contributor

nico commented Jul 17, 2015

Note that Chromium hacked around this: https://code.google.com/p/open-vcdiff/issues/detail?id=33#c11

It'd still be nice if that hack wasn't needed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Priority-High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nico @Steelskin