My favorites | Sign in
Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 81: Check if ORO is replacable with java.util.regex
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  lars.heuer
Closed:  Jul 20
Type-Enhancement
Priority-Low
Component-DB2TM
Component-webed
Release5.0.1


Sign in to add a comment
 
Reported by lars.heuer, Jul 19, 2009
Check if Apache ORO is replaceable with java.util.regex 
Comment 1 by larsga, Jul 19, 2009
It would be wonderful if we could drop that dependency. Every dependency dropped is 
a big gain, as far as I'm concerned.

Here are the uses of ORO:
./net/ontopia/Ontopia.java:    checkClass
("org.apache.oro.text.regex.MalformedPatternException", "oro.jar");
./net/ontopia/topicmaps/db2tm/Values.java:import org.apache.oro.text.regex.*;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.MalformedPatternException;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Pattern;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Perl5Compiler;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Perl5Matcher;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.MalformedPatternException;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Pattern;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Perl5Compiler;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Perl5Matcher;
./net/ontopia/topicmaps/webed/webapps/omnieditor/
ShowActionGroupParamRule.java:import org.apache.oro.text.perl.Perl5Util;

Status: Accepted
Comment 2 by indiapaleale, Jul 19, 2009
I agree. Feel free to replace oro.jar with java.util.regex.
Comment 3 by larsga, Jul 20, 2009
r344 removes the dependency on ORO from the LTM writer.
Labels: Component-DB2TM Component-webed
Comment 4 by lars.heuer, Jul 20, 2009
This issue was updated by r346.

ProcessServlet never used ORO, unused import
Comment 5 by larsga, Jul 20, 2009
The ShowActionGroupParamRule class is used by the webed test suite, but I'm not sure 
the test suite uses it very much. It's quite possible that one can get rid of it 
entirely. (Would be nice if we could.)

DB2TM seems to provide regexp matching to external code. Haven't fully understood 
that part of the code yet.
Comment 6 by lars.heuer, Jul 20, 2009
This issue was updated by r347.

Converted ShowActionGroupParamRule to java.util.regex
Comment 7 by lars.heuer, Jul 20, 2009
Added a separate issue #86 to decide if ShowActionGroupParamRule is needed at all
Labels: -Component-webed
Comment 8 by lars.heuer, Jul 20, 2009
Removed label by mistake
Labels: Component-webed
Comment 9 by lars.heuer, Jul 20, 2009
This issue was closed by r348.
Status: Fixed
Comment 10 by larsga, Sep 01, 2009
(No comment was entered for this change.)
Labels: Release5.0.1
Sign in to add a comment

Hosted by Google Code