Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-specific methods in FileUtils #395

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 4 comments
Closed

Test-specific methods in FileUtils #395

GoogleCodeExporter opened this issue Mar 16, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

net.ontopia.utils.FileUtils was originally a class containing only generic File 
utility methods, but has now been extended with methods that contain lots of 
logic and assumptions from the test framework. I suggest a TestUtils or 
TestFileUtils class would be a better home for these methods. (Basically lines 
180 and out.)

However, Morpheus originally did it this way, and then moved the methods into 
FileUtils. PPK is the only one who knows why, and he's on holiday, so we're 
waiting for him to return so we can hear his rationale before we decide what to 
do.

Original issue reported on code.google.com by lar...@gmail.com on 13 Jul 2011 at 10:22

@GoogleCodeExporter
Copy link
Author

Seems this issue is already accepted by me ;). I will split the FileUtils into 
the original FileUtils and a new TestFileUtils class.

Original comment by p.kruijsen on 25 Jul 2011 at 12:26

@GoogleCodeExporter
Copy link
Author

Well, it was stuck waiting for further action from you (basically a response). 
But if you will do it that's great.

Original comment by lar...@gmail.com on 25 Jul 2011 at 1:50

@GoogleCodeExporter
Copy link
Author

Fixed in revision r2165

Original comment by p.kruijsen on 29 Jul 2011 at 12:57

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by qsieb...@gmail.com on 27 Jan 2012 at 11:05

  • Added labels: Release5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant