Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopicMap/TopicMapSystem.close() don't commit the current transaction in RDBMS backends #228

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?

1. Create a (TMAPI 2.0) TopicMap object that accesses a PostgreSQL backend as 
described in 
http://code.google.com/p/ontopia/wiki/TMAPI2 ("How to access the 
implementation")
2. Change the topic map, e.g. 
    Topic t = tm.createTopic();
3. Close the topic map
    tm.close();

What is the expected output? What do you see instead?

Changes to the topic map via TMAPI are not committed to the database. It is 
possible to commit 
by converting the TopicMap object into a TopicMapImpl object, get its wrapped 
TopicMapIF and 
call the stores commit function:

TopicMapIF tmif = ((TopicMapImpl)tm).getWrapped();
tmif.getStore().commit();

As long as TMAPI has no native support for committing changes, at least 
TopicMap.close() and 
TopicMapSystem.close() should commit the transaction. Maybe TopicMapImpl could 
have a non-
TMAPI commit() function to allow committing changes without the need to either 
close the 
TopicMap object or convert into a TopicMapIF.

TMAPI calls should NOT always call commit(), as this will have performance 
issues (as pointed out 
by Lars Marius). 

Original issue reported on code.google.com by jan.schr...@gmail.com on 7 Apr 2010 at 5:04

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision r977.

Original comment by lars.he...@gmail.com on 7 Apr 2010 at 9:56

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by lar...@gmail.com on 10 Jun 2010 at 12:06

  • Added labels: Component-TMAPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant