Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variants allow empty scope #209

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 10 comments
Closed

Variants allow empty scope #209

GoogleCodeExporter opened this issue Mar 16, 2015 · 10 comments
Labels
Component-TMAPI Defect GoogleCode Priority-Medium

Comments

@GoogleCodeExporter
Copy link 

What steps will reproduce the problem?
1. create a topic map with a topic and a name without scoping topics
2. call name.createVariant (using TMAPI 2.0) without passing a scope
3. it runs just fine

What is the expected output? What do you see instead?

I expected a "variant must not be in the uncoinstrained scope" exception.

Maybe this should be solved together with #87.

Original issue reported on code.google.com by bnjmn...@gmail.com on 19 Feb 2010 at 10:06
@GoogleCodeExporter
Copy link
Author 

Strange that this is not covered by the TMAPI test suite. I thought we covered 
UCS
and variants. 

The test case which verifies that the bug is fixed should be contributed to the 
TMAPI
project.

Original comment by lars.he...@gmail.com on 19 Feb 2010 at 12:32

  • Added labels: Component-TMAPI

@GoogleCodeExporter
Copy link
Author 

Actually, we test for illegal the illegal UCS:

TestName, line 155
http://tmapi.svn.sourceforge.net/viewvc/tmapi/trunk/src/test/java/org/tmapi/core
/TestName.java?revision=64&view=markup

Original comment by lars.he...@gmail.com on 19 Feb 2010 at 12:44

@GoogleCodeExporter
Copy link
Author 

Added one more test to TestName.
Whoever fixes this bug should run Ontopia's TMAPI implementation against TMAPI's
trunk (at min. rev. 146).

Original comment by lars.he...@gmail.com on 19 Feb 2010 at 12:59

@GoogleCodeExporter
Copy link
Author 

We just digged into that a bit deeper. Sorry for the imprecise first report. 
The TMAPI 
tests should also check the 2 createVariant methods which include a datatype 
(both, 
Collection and variable-argument-array as scope). We originally found it with 
the 
datatype given + empty array version.

Original comment by bnjmn...@gmail.com on 19 Feb 2010 at 1:19

@GoogleCodeExporter
Copy link
Author 

Ok. We do not check this kind of stuff in TMAPI, I think. So, the person who 
fixes
this bug should contribute that test case to TMAPI. BTW, it's always a good 
idea if
the *reporter* provides a test case to avoid confusion.

Original comment by lars.he...@gmail.com on 19 Feb 2010 at 1:32

@GoogleCodeExporter
Copy link
Author 

I attached a patch to the TMAPI tests at https://sourceforge.net/tracker/?
func=detail&aid=2954979&group_id=39237&atid=424686

Original comment by bnjmn...@gmail.com on 19 Feb 2010 at 2:17

@GoogleCodeExporter
Copy link
Author 

Patched TMAPI's trunk, thank you.

Original comment by lars.he...@gmail.com on 19 Feb 2010 at 2:32

@GoogleCodeExporter
Copy link
Author

Original comment by lar...@gmail.com on 4 Mar 2010 at 11:06

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author 

You can use the TMAPI 2.0.1 (snapshot) test suite to reproduce (and fix) the 
error

Original comment by lars.he...@gmail.com on 4 Mar 2010 at 12:01

@GoogleCodeExporter
Copy link
Author 

This issue was closed by revision r931.

Original comment by h.niederhausen@googlemail.com on 4 Mar 2010 at 1:28

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-TMAPI Defect GoogleCode Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter