Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-normative recommended behavior for writing comments #29

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 6 comments
Closed

non-normative recommended behavior for writing comments #29

GoogleCodeExporter opened this issue Mar 12, 2015 · 6 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

(informative)

where numeric IDs are used, write out the name when generating obo

E.g.

is_a: FOO:0000001 ! <name of foo1>
relationship: part_of FOO:0000002 ! <name of foo2>
relationship: FOO:0000003 FOO:0000004 <name of foo3> <name of foo4>

TODO:

1. add this as informative comments to spec (cjm)
2. add to oboformat writer (Shahid)

Original issue reported on code.google.com by cmung...@gmail.com on 26 May 2011 at 3:55
@GoogleCodeExporter
Copy link
Author

Original comment by shahid.m...@gmail.com on 16 Jun 2011 at 6:35

@GoogleCodeExporter
Copy link
Author 

It is fixed.

Original comment by shahid.m...@gmail.com on 17 Jun 2011 at 8:05

@GoogleCodeExporter
Copy link
Author 

Issue 11 has been merged into this issue.

Original comment by shahid.m...@gmail.com on 17 Jun 2011 at 9:52

@GoogleCodeExporter
Copy link
Author 

Note - not fixed in -r123.

e.g. 

[Term]
id: FBbt:00007122
name: dorsal posterior protocerebral tract
is_a: FBbt:00007426 ! ipsilateral tract
relationship: part_of FBbt:00001920 ! embryonic/larval brain

[Typedef]
id: part_of
name: part_of
xref: BFO:0000050

> OBO2OWL2OBO >

[Term]
id: FBbt:00007122
name: dorsal posterior protocerebral tract
is_a: FBbt:00007426 ! ipsilateral tract
relationship: BFO:0000050 FBbt:00001920 ! embryonic/larval brain

[Typedef]
id: BFO:0000050
name: part_of

(Typedefs added for context)


relationship: BFO:0000050 FBbt:00001920 ! embryonic/larval brain
should be
relationship: BFO:0000050 FBbt:00001920 ! part_of embryonic/larval brain

Original comment by dosu...@gmail.com on 20 Jun 2011 at 11:48

@GoogleCodeExporter
Copy link
Author 

fixed.

Original comment by shahid.m...@gmail.com on 20 Jun 2011 at 4:35

@GoogleCodeExporter
Copy link
Author

Original comment by shahid.m...@gmail.com on 7 Jul 2011 at 10:12

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter